refactor(styleguide): improve emotion buttons and header responsiveness
Created by: Tirokk
Authored by alina-beck Merged
🍰 Pullrequest
During the migration of the styleguide buttons I found several HTML/CSS issues I just had to fix – couldn’t stop myself…
This PR sums them up:
- replaces the last few instances of
ds-button
withbase-button
- makes sure the
delete data
button is only enabled while the user name matches the text input (so far it was just enabled once but not disabled again when the user added/removed characters) - moves
embed
related CSS classes to theEmbedComponent
file - fixes
EmotionsButtons
markup (before, theds-flex-items
were not having any effect because they were wrapped in additionaldivs
) - removes the
LoadMore
button because it was no longer displayed - moves the
dropdown-arrow
class tomain.scss
to make sure it loads in the correct order - improves markup and design of
Paginate
component - slightly improves header responsiveness by overriding styleguide-inline-styles (cleaning this up properly is on my todo list for next year…)
- refactors the
SearchableInput
component to use less wrapperdivs
and less CSS
ToDo
-
merge PR #2562 -
rebase this PR to master -
approve and merge this one! 😉