Skip to content

refactor(styleguide): improve emotion buttons and header responsiveness

Hannes Heine requested to merge pr2582head into pr2582base

Created by: Tirokk

alina-beck Authored by alina-beck Merged


🍰 Pullrequest

During the migration of the styleguide buttons I found several HTML/CSS issues I just had to fix – couldn’t stop myself… 😊

This PR sums them up:

  • replaces the last few instances of ds-button with base-button
  • makes sure the delete data button is only enabled while the user name matches the text input (so far it was just enabled once but not disabled again when the user added/removed characters)
  • moves embed related CSS classes to the EmbedComponent file
  • fixes EmotionsButtons markup (before, the ds-flex-items were not having any effect because they were wrapped in additional divs)
  • removes the LoadMore button because it was no longer displayed
  • moves the dropdown-arrow class to main.scss to make sure it loads in the correct order
  • improves markup and design of Paginate component
  • slightly improves header responsiveness by overriding styleguide-inline-styles (cleaning this up properly is on my todo list for next year…)
  • refactors the SearchableInput component to use less wrapper divs and less CSS

ToDo

  • merge PR #2562
  • rebase this PR to master
  • approve and merge this one! 😉

Merge request reports