Update ds-avatar size to use small
Created by: Tirokk
Authored by mattwr18 Merged
Pullrequest
I was able to track down the origin of this issue to the User
component by running each directories tests one at a time, seeing where they failed, and commenting out the hc-user
component, which gave green tests.
I was able to get all the tests without this warning by commenting out the ds-avatar
component in the User
component.
I had a look at the human-connection/styleguide
and found this commit, which seems to suggest that we can be/should be passing in the size prop of ds-avatar
as small, base, large
etc...
I changed all instances for ds-avatar
in the code base with their respective English sizes, but then the UI showed an x-large avatar on the root path.
I was able to get passed this by only changing the first ds-avatar
, there are now no Vue warnings in the test, and the UI looks fine.
@appinteractive, am I missing something here?
Issues
- fixes #586 (closed)