Skip to content

feat(other): [WIP] 🍰 Validate Group Name Etc. In Backend – #2

Hannes Heine requested to merge 5425-validate-group-name-etc-in-backend--#2 into master

Created by: Tirokk

🍰 Pullrequest

Validate Group Name Etc. In Backend – #2 (closed).

Issues

Todo

I created a different issue on which @Mogge tries to find a better way to sanitize HTML #5668 (closed)

  • rename GROUPNAME_… β†’ GROUP_NAME_…
  • rename GROUPDESCRIPTION_… β†’ GROUP_DESCRIPTION_…
  • rename USERNAME_MIN_LENGTH β†’ USERNAME_LENGTH_MIN
  • rename COMMENT_MIN_LENGTH β†’ COMMENT_LENGTH_MIN
  • use xssMiddleware.js to sanitize HTML:
    • I created a different issue on which @Mogge tries to find a better way to sanitize HTML #5668 (closed)
    • description and therefore
      • rename description β†’ groupDescription
    • descriptionExcerpt and therefore
      • rename descriptionExcerpt β†’ groupDescescriptionExcerpt
  • migration for Group node:
    • groupDescription:
      • change fulltext index as well
      • rename description β†’ groupDescription
      • remove inappropriate HTML like in xssMiddleware.js?
    • groupDescriptionExcerpt:
      • rename descriptionExcerpt β†’ groupDescriptionExcerpt
      • remove inappropriate HTML like in xssMiddleware.js?
  • restrict in backend:
    • GROUPNAME_LENGTH_MIN
    • GROUPNAME_LENGTH_MAX
    • test this both
  • merge new master
  • clean up: search for Wolle

Merge request reports