Skip to content

296 image component

Hannes Heine requested to merge pr499head into pr499base

Created by: Tirokk

roschaefer Authored by roschaefer Merged


Pullrequest

This PR adds a custom <img> component which we can use throughout the webapp. The webapp proxies all requests to uploads to the backend, therefore we can assume that any relative image src files come from the backend. The component checks if the image src attribute is a relative URL and if yes, it prefixes it with /api which is the proxied path to the backend.

Issues

Checklist

  • @tansaku @aonomike could you finish this PR please? You are part of team volunteers and you should have write permissions to this branch.

How2Test

  • cd webapp && yarn run test components/Image/

Todo

  • Implement imageSrc computed property
  • Replace all img tags with this component

Merge request reports