Skip to content
Snippets Groups Projects

feat: :fire: Displaying Social Media Favicons On Profile Page

Merged feat: :fire: Displaying Social Media Favicons On Profile Page
3505-display-social-media-favicons-on-profile into master
Merged Hannes Heine requested to merge 3505-display-social-media-favicons-on-profile into master

Created by: nimitbhargava

:cake: Pullrequest

Issues

Merge request reports

Merged by avatar (Oct 8, 2025 10:01pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Created by: Mogge

    Review: Changes requested

    Great job so far. Everything is working fine and we have a new component for the social media! Is it true, that the only relevant change was using img instead of user-avatar? I am looking forward to see the tests.

  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Created by: Tirokk

    Review: Commented

    This component looks really nice @nimitbhargava ! :rocket::dizzy:

    Thanks a lot that you go for this !!! :four_leaf_clover::hugging:

    I found one thing which maybe came not in by you, but would be nice to have it more nicely. When one edit a social media the input field is really small. Would be cool to have it the width of the field for adding a social media:

    Bildschirmfoto 2020-12-15 um 17 43 56
  • Hannes Heine
    Hannes Heine @Elweyn started a thread on commit ef03319e
webapp/components/SocialMedia/SocialMedia.vue
13 </a>
14 </ds-space>
15 </template>
16 </ds-space>
17 </base-card>
18 </ds-space>
19 </template>
20
21 <script>
22 export default {
23 name: 'social-media',
24 props: {
25 userName: {},
26 user: {},
27 },
28 methods: {
  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Created by: Mogge

    Review: Changes requested

    Please see the subbranch for hints for the tests

  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Created by: Mogge

    Review: Approved

    Congratulations! Your first PR will be merged to master. Thank you very much for your contribution.

  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Merged by: Mogge at 2020-12-22 12:06:40 UTC

    • Please register or sign in to reply