Skip to content
Snippets Groups Projects

feat: :cake: Allow Only Supported Image File Formats

Merged feat: :cake: Allow Only Supported Image File Formats
allow-only-supported-file-formats into master
Merged Hannes Heine requested to merge allow-only-supported-file-formats into master

Created by: dasari810

:cake: Pullrequest

  • to automatically filter only the supported image file formats when the user uploads the image for creating post

  • to give an error message if an unsupported file format is uploaded ( post will not be created )

Issues

Todo

  • None

Merge request reports

Merged by avatar (May 19, 2025 10:24am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hannes Heine
    Hannes Heine @Elweyn started a thread on commit 939466b9
    • webapp/components/ImageUploader/ImageUploader.spec.js
    27 27 beforeEach(() => jest.useFakeTimers())
    28 28 const message = 'File upload failed'
    29 29 const fileError = { status: 'error' }
    30 const unSupportedFileMessage =
    31 'Please upload an image of file format : jpg , jpeg , png or gif'
    30 32
    31 33 it('shows an error toaster when verror is called', () => {
    32 34 wrapper.vm.onDropzoneError(fileError, message)
    33 35 expect(mocks.$toast.error).toHaveBeenCalledWith(fileError.status, message)
    34 36 })
    37 it('shows an error toaster when unSupported file is uploaded', () => {
  • Hannes Heine
  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Created by: Tirokk

    Review: Changes requested

    Hey @dasari810 , nice that you did this PR as well. :rocket::dizzy:

    This makes thinks much more clear and brings our project forward !!!

    I have little changes requested …

    PS: I merge the master …

  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Created by: Tirokk

    Review: Approved

    Hey cool @dasari810 , thanks for contributing again !!! :rocket::dizzy:

    A nice next step for a better user experience!

    PS: I allowed my self to add the German language and add the branch 3921-set-up-travis-builds so that the Travis builds can run now …

    PPS: In case you are keen on being perfect: There are two toast messages if an error occurs. But I already approved your PR … :hugging:

    Bildschirmfoto 2020-11-03 um 15 15 29
  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Created by: ogerly

    Review: Approved

  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Merged by: Mogge at 2021-02-04 14:22:03 UTC

    • Please register or sign in to reply