Skip to content

refactor: deprecated slot syntax [2117]

Hannes Heine requested to merge pr3258head into pr3258base

Created by: Tirokk

rbeer Authored by rbeer Merged


🍰 Pullrequest

Following https://vuejs.org/v2/guide/components-slots.htmlNamed-Slots We are using deprecated syntax in various places in our code base In short, <template slot="index" slot-scope="scope"> can be refactored to <template #index="scope"> Motivation for this change, and more examples can be found here https://github.com/vuejs/rfcs/blob/master/active-rfcs/0001-new-slot-syntax.md

Issues

Todo

  1. use shorthand for default slots
  2. Some test failures are seemingly caused by <ds-*> not handling the new syntax well. If so, and since they are supposed to be refactored out anyway, this might be a blocker. Turns out, components are not the cause. Just didn't understand the new syntax, fully. (see comment)

Merge request reports