Skip to content

refactor: migrate card component

Hannes Heine requested to merge pr2870head into pr2870base

Created by: Tirokk

alina-beck Authored by alina-beck Merged


🍰 Pullrequest

  • replaces the ds-card component from the styleguide with a new base-card component
  • adds a CardWithColumns component (for two-column layouts like LoginForm)
  • refactors and renames Comment component --> CommentCard
  • refactors TeaserImage
  • refactors ContributionForm
  • refactors CategoriesSelect
  • refactors Notification
  • refactors and improves design of DeleteData
  • refactors, adjusts design and renames PostCard --> PostTeaser
  • refactors and improves design of LoginForm

ToDo

  • replace magic numbers with variables 😉
  • wait for PR #2585 to be merged into master
  • merge master into this branch
  • rename TeaserImage to ImageUploader

maybe in separate PRs:

  • remove unimplemented pages (and make sure we have issues for all the features)
  • refactor post page and profile page

Design Changes

delete data before: Screenshot 2020-02-11 at 10 10 12

delete data after: Screenshot 2020-02-11 at 10 10 31

post card before: Screenshot 2020-02-11 at 10 11 53

post card after: Screenshot 2020-02-11 at 10 14 56

login form before: Screenshot 2020-02-10 at 15 44 06

login form after: Screenshot 2020-02-10 at 15 43 07

Issues

Merge request reports