Skip to content
Snippets Groups Projects

Get rid of inconsistency with neode setup

Closed Get rid of inconsistency with neode setup
pr2404head into pr2404base
2 unresolved threads
Closed Hannes Heine requested to merge pr2404head into pr2404base
2 unresolved threads

Created by: Tirokk

roschaefer Authored by roschaefer Merged

:cake: Pullrequest

Implement getDriver() and getNeode() the same way

I want to introduce `neode` and `neo4j-graphql-js` to my students and
saw this.
Fix cypress tests

Since `dotenv` in the backend now loads configuration from a file
relative to the current file, we don't have to duplicate the neo4j
configuration settings here.

Merge request reports

Approval is optional

Closed by avatar (May 20, 2025 7:24pm UTC)

Merge details

  • The changes were not merged into pr2404base.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
backend/src/middleware/hashtags/hashtagsMiddleware.spec.js
36 36 context: () => {
37 37 return {
38 38 user: authenticatedUser,
39 neode: instance,
39 neode,
  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Created by: Tirokk

    mattwr18 Authored by mattwr18

    Outdated (history rewrite) - original diff

    @@ -36,7 +36,7 @@ beforeAll(() => {
     context: () => {
       return {
         user: authenticatedUser,
-        neode: instance,
+        neode: neode,
    Suggested change
    39 neode,
    39 neode,

    can't we use ES6 syntax here?

  • Please register or sign in to reply
  • Hannes Heine
    Hannes Heine @Elweyn started a thread on commit a3251710
    • backend/src/schema/resolvers/users/blockedUsers.spec.js
    20 20 return {
    21 21 user: authenticatedUser,
    22 22 driver,
    23 neode: instance,
    23 neode,
    • Hannes Heine
      Hannes Heine @Elweyn ·
      Author Owner

      Created by: Tirokk

      mattwr18 Authored by mattwr18

      Outdated (history rewrite) - original diff

      @@ -20,7 +20,7 @@ beforeEach(() => {
       return {
         user: authenticatedUser,
         driver,
-        neode: instance,
+        neode: neode,
      Suggested change
      23 neode,
      23 neode,

      same as :point_up_2:

    • Please register or sign in to reply
  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Created by: Mogge

    Review: Changes requested

    Looks good, just requested two small changes @roschaefer

  • Hannes Heine
    Hannes Heine @Elweyn ·
    Author Owner

    Created by: Mogge

    Review: Approved

    • Please register or sign in to reply