Created by: Tirokk
Authored by alina-beck Merged
Replaces <ds-icon>
from the styleguide with a new <base-icon>
directly in our repo.
BaseIcon
BaseIcon
for component testsA few things that are good to know:
_new
folder into the existing folders when adding new stuff because Nuxt.js forces a particular folder structure on us and there is currently no way to change it (this is also reflected in the docs)generics
folder that are prefixed with Base
will be globally available and don't have to be imported. But: changes made to these components will only be visible when rebuilding the frontend! (So when you work on BaseComponents
make sure to import them like regular components temporarily, to see changes reflected immediately.).svg
file from the styleguide into the /assets/_new/icons/svgs
folder! (I'll try to find/set up a good way to search all available icons.)A ton of files changed just because...
<ds-icon>
with <base-icon>
--> many .vue
files can be ignored,svgs
from the styleguide --> all .svg
files can be safely ignored,localVue
import in all test files --> all .spec.js
files can be ignoredPlease have a look at:
webapp/README.md
webapp/assets/_new/icons/index.js
webapp/components/Category/index.vue
webapp/components/DropdownFilter/DropdownFilter.vue
webapp/components/LocaleSwitch/LocaleSwitch.vue
webapp/components/User/User.vue
webapp/components/_new/generic/BaseIcon/BaseIcon.story.js
webapp/components/_new/generic/BaseIcon/BaseIcon.vue
webapp/package.json
webapp/plugins/base-components.js
webapp/storybook/config.js
webapp/storybook/webpack.config.js
webapp/test/fileMock.js
webapp/test/registerContext.js
webapp/test/testSetup.js
That should be all the relevant changes.