Skip to content
Snippets Groups Projects

Max aspect ratio of 1:1 for Post index page

Closed Hannes Heine requested to merge pr1796head into pr1796base

Created by: Tirokk

mattwr18 Authored by mattwr18 Merged


  • we are currently enforcing a 1:1 max ratio on the root path and would like to maintain consistency

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
197 197
198 198 .ds-card-image {
199 199 img {
200 height: 300px;
200 max-height: 710px;
  • Created by: Tirokk

    roschaefer Authored by roschaefer


    Outdated (history rewrite) - original diff


    @@ -197,7 +197,7 @@ export default {
     
         .ds-card-image {
           img {
    -        height: 300px;
    +        max-height: 710px;

    Has this not been changed by @vbelolapotkov for a some reason? Code creep? :laughing:

  • Created by: Tirokk

    mattwr18 Authored by mattwr18


    it was changed by his PR yes... but as I pointed out to him, the reason I didn't like the change is cause we would need to change it when we deal with this issue. There is simply no way to enforce a 1:1 aspect ration with a fixed width unless we also limit the height. I did double check the scroll functionality to check if it were broken in the way he described and it wasn't, but a lot changed on that PR before it was merged. hehehe code creep is when you change code that doesn't have anything to do with the ticket, as I explained above... this is the only change relevant to the issue :stuck_out_tongue:

  • Created by: Tirokk

    mattwr18 Authored by mattwr18


    Though, I think 710px is not actually a 1:1 ratio, since the Post page has a width of 910px, I guess

  • Created by: Tirokk

    mattwr18 Authored by mattwr18


    As discussed in the issue about image cropping though, if we are inflexible with the width of the Post, then enforcing a max 1:1 means that the user would need to scroll to see anything other than the Post image

  • Created by: Mogge

    Review: Approved

    Looks good to me! Feel free to merge. I just wanted to point out my comment below :point_down:

  • Please register or sign in to reply
    Loading