Skip to content
Snippets Groups Projects

Add styleguide as submodule

Closed Hannes Heine requested to merge pr1559head into pr1559base

Created by: Tirokk

roschaefer Authored by roschaefer Merged


:cake: Pullrequest

Add styleguide/ as submodule

This should make new contributors aware that the Styleguide exists and
maybe maybe even encourage people to contribute to the Styleguide.

Also this enabled `yarn run dev:styleguide` to build the `webapp/` along
with the styleguide.

Issues

  • None

Todo

  • If we decide to merge this PR, we should setup dependabot to automatically update the submodule. The policy should be to automatically merge a new commit of the submodule, because it's the same team that reviews PRs in this repo as well in this repo.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: Mogge

    Review: Approved

    Looks fine to me. :thumbsup_tone2: As far as I can say. @roschaefer

    Do you have spoken with @appinteractive about this?

Please register or sign in to reply