Skip to content
Snippets Groups Projects

Filter posts by emotions

Closed Hannes Heine requested to merge pr1490head into pr1490base

Created by: Tirokk

mattwr18 Authored by mattwr18 Merged


:cake: Pullrequest

Issues

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: Mogge

    Review: Approved

    fantastic

    I have nothing to complain about this PR that would keep it from being merged! Great work!

    The only thing I ask myself: I guess Dennis wanted to have a negative filter: If I deselect an emotion, there should be no posts with the deselected emotion. Right now, I guess we have a positive filter: If I select an emotion, every post must have the emotion. Am I right? @mattwr18

    I would say let's keep this behaviour. There might be performance issues, because it's always more expensive to search for sth. that is not there instead of searching for sth. that is.

    Also the naming "GeneralFilterItems" is not very obvious to me.

Please register or sign in to reply
Loading