Filter posts by emotions

Created by: Tirokk

Authored by mattwr18 Sep 5, 2019 Merged Sep 10, 2019

---

• Co-authored-by: Brent Vardy brent.vardy@challengelogic.net
• Co-authored-by: Mike Aono aonomike@gmail.com
• Co-authored-by: Harald harald.reingruber@gmx.at @Tirokk was there as well

Pullrequest

Issues

• fixes #1488 (closed)

Created by: Mogge

Review: Approved

I have nothing to complain about this PR that would keep it from being merged! Great work!

The only thing I ask myself: I guess Dennis wanted to have a negative filter: If I deselect an emotion, there should be no posts with the deselected emotion. Right now, I guess we have a positive filter: If I select an emotion, every post must have the emotion. Am I right? @mattwr18

I would say let's keep this behaviour. There might be performance issues, because it's always more expensive to search for sth. that is not there instead of searching for sth. that is.

Also the naming "GeneralFilterItems" is not very obvious to me.