1414 Bugfix: Delete notifications if connected post, comment or user is deleted

Created by: Tirokk

Authored by roschaefer Aug 29, 2019 Merged Aug 30, 2019

---

🍰 Pullrequest

Issues

• #1414 (closed) see below
• fix: #1332 (closed)
• close: #1353 (closed)

Todo

• bug report at cypress-cucumber-preprocessor about silently failing scenario I don't have a build at hand that's silently failing, so I keep that for later when I'm able to reproduce this issue again
• write more backend test to check what happens if you would create the same notification again, e.g. if sb. updates the post and re-mentions the user. (It will probably create another relationship)
• update database migration we don't import notifications :woman_facepalming:

EDIT: I just tested out if the bug is actually fixed, turns out: No. We can still have a dangling pointer if a comment notified a user and the post of the comment was deleted. Deleting a post will not delete its comments. So we have comments without posts in the database.