Skip to content

馃悰 [Bug] Editor using LegacyEmbed, only

Created by: Tirokk

rbeer Authored by rbeer

馃悰 Bugreport

Editor embeds are being saved in the legacy inline format. When defining both Embed and LegacyEmbed in defaultExtensions.js, the latter definition always takes precedence.

The new block level format has therefore been in use for only 6 days (2019-11-15 - 2019-11-22).

Steps to reproduce the behavior

  1. Add a comment or post with embed
  2. Check content field on that Post's query result
  3. Embed <a> is inline, i.e. inside of <p>

Expected behavior

Embeds' <a> are inserted at block-level.

Timeline

  • #1937 (closed) reports a bug with hashtags after embeds not being transformed
  • #2242 fixes #1937 (closed) by changing Embed from inline to block level
  • #2259 (closed) reports a bug that existing embeds (inline markup in DB) aren't displayed
  • #2328 introduces LegacyEmbed, which functionally reverts #2242

Todo

  • ensure paragraphs present above and below embed
    • the embed taking up all the space in the editor view makes it almost impossible to add text, when you paste a video url into an empty editor
  • migrate old posts to new block format
  • fix pasteRule expression (Appendix B, rfc3986) (merged from #2238 (closed))